netdev - Re: [xdp-hints] Re: [PATCH bpf-next v3 00/11] xdp: hints via kfuncs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Nov 2022 19:56:35 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Martin KaFai Lau <martin.lau@...ux.dev>, bpf@...r.kernel.org,
        ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        song@...nel.org, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, haoluo@...gle.com, jolsa@...nel.org,
        David Ahern <dsahern@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Anatoly Burakov <anatoly.burakov@...el.com>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        Maryam Tahhan <mtahhan@...hat.com>, xdp-hints@...-project.net,
        netdev@...r.kernel.org,
        Toke Høiland-Jørgensen 
        <toke@...hat.com>
Subject: Re: [xdp-hints] Re: [PATCH bpf-next v3 00/11] xdp: hints via kfuncs

On Wed, 30 Nov 2022 16:32:47 -0800 Stanislav Fomichev wrote:
> Makes sense. Let me take a closer look. I glanced at it last week and
> decided that maybe it's easier to not hold the device at all..
> 
> Maybe we should have something like this:
> 
> - bpf_prog_is_dev_bound() - prog is dev bound but not offloaded
> (currently bpf_prog_is_dev_bound == fully offloaded)
> - bpf_prog_is_offloaded() - prog is dev bound and offloaded
> 
> So hopefully I can leverage some/most existing bpf_prog_is_dev_bound
> call sites (+ add some more to reject prog_run/etc).

+1, FWIW, seems like it'd improve the code readability quite a bit.