netdev - Re: [PATCH v2 1/1] sctp: sysctl: make extra pointers netns aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4gpYPlWNLe5o8Hy@suse.com>
Date:   Thu, 1 Dec 2022 12:11:12 +0800
From:   Firo Yang <firo.yang@...e.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     marcelo.leitner@...il.com, vyasevich@...il.com,
        nhorman@...driver.com, mkubecek@...e.com, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, linux-sctp@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        firogm@...il.com
Subject: Re: [PATCH v2 1/1] sctp: sysctl: make extra pointers netns aware

The 11/29/2022 20:48, Jakub Kicinski wrote:
> On Fri, 25 Nov 2022 20:11:27 +0800 Firo Yang wrote:
> > +#define SCTP_RTO_MIN_IDX       1
> > +#define SCTP_RTO_MAX_IDX       2
> > +#define SCTP_PF_RETRANS_IDX    3
> > +#define SCTP_PS_RETRANS_IDX    4
> 
> Use these to index the entries, please, like this:
> 
> struct bla table[] = {
> 	[MY_INDEX_ONE] = {
> 		.whatever = 1,
> 	},
> 	[MY_INDEX_TWO] = {
> 		.fields = 2,
> 	},
> 	{
> 		.there = 3,
> 	},
> 	{
> 		.are = 4,
> 	},
> };
> 
> I think that works even without all entries in the table having the
> index.. ?
> 

Cool. I will send a V3.

Thanks,
// Firo