netdev - Re: [PATCH iproute2-next v2 1/2] dcb: add new pcp-prio parameter to dcb app

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4m925XVWIeeunLX@DEN-LT-70577>
Date:   Fri, 2 Dec 2022 08:45:45 +0000
From:   <Daniel.Machon@...rochip.com>
To:     <dsahern@...nel.org>
CC:     <netdev@...r.kernel.org>, <stephen@...workplumber.org>,
        <petrm@...dia.com>, <maxime.chevallier@...tlin.com>,
        <vladimir.oltean@....com>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH iproute2-next v2 1/2] dcb: add new pcp-prio parameter to
 dcb app

> On 11/28/22 5:38 AM, Daniel Machon wrote:
> > @@ -344,6 +420,17 @@ static int dcb_app_print_key_dscp(__u16 protocol)
> >       return print_uint(PRINT_ANY, NULL, "%d:", protocol);
> >  }
> >
> > +static int dcb_app_print_key_pcp(__u16 protocol)
> > +{
> > +     /* Print in numerical form, if protocol value is out-of-range */
> > +     if (protocol > 15) {
> 
> 15 is used in a number of places in this patch. What's the significance
> and can you give it a name that identifies the meaning? i.e., protocol
> is a u16 why the 15 limit? (and update all places accordingly)

Hi David,

As Petr pointed out. The value 15 is the maximum number of PCP+DEI
values (0-7 for DEI=0 and 8-15 for DEI=1) I will add the suggested
change in a new version.

/Daniel