netdev - Re: [PATCH] netfilter: nfnetlink: check 'skb->dev' pointer in nfulnl_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4nRc3fIxQDzADyV@kadam>
Date:   Fri, 2 Dec 2022 13:20:35 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Li Qiong <liqiong@...china.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, coreteam@...filter.org,
        Yu Zhe <yuzhe@...china.com>
Subject: Re: [PATCH] netfilter: nfnetlink: check 'skb->dev' pointer in
 nfulnl_log_packet()

On Fri, Dec 02, 2022 at 04:33:04PM +0800, Li Qiong wrote:
> The 'skb->dev' may be NULL, it should be better to check it.
> 
> Signed-off-by: Li Qiong <liqiong@...china.com>
> ---

This needs a Fixes tag as well.

Here my records show that I looked at this in 2018 but I probably
ignored it based on that the code was introduced in 2012.  When warnings
are really ancient sometimes I just assume they must be false positives
or someone would have hit it in testing.

Also for really ancient bugs, it's hard to contact the original author
or they have forgotten the details of the code.

regards,
dan carpenter