netdev - Re: [PATCH net-next v2 1/3] ethtool: add tx aggregation parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGRyCJHMASBF1QVys_Pi62Mi0pCu1oft=zBsT5s_GbXxY_yuRg@mail.gmail.com>
Date:   Fri, 2 Dec 2022 12:42:50 +0100
From:   Daniele Palmas <dnlplm@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>,
        Sean Tranchetti <quic_stranche@...cinc.com>,
        Jonathan Corbet <corbet@....net>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Gal Pressman <gal@...dia.com>,
        Bjørn Mork <bjorn@...k.no>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/3] ethtool: add tx aggregation parameters

Hello Jakub,

Il giorno ven 2 dic 2022 alle ore 01:21 Jakub Kicinski
<kuba@...nel.org> ha scritto:
>
> On Wed, 30 Nov 2022 13:46:14 +0100 Daniele Palmas wrote:
> > Add the following ethtool tx aggregation parameters:
>
> > diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> > index bede24ef44fd..ac51a01b674d 100644
> > --- a/Documentation/networking/ethtool-netlink.rst
> > +++ b/Documentation/networking/ethtool-netlink.rst
> > @@ -1002,6 +1002,9 @@ Kernel response contents:
> >    ``ETHTOOL_A_COALESCE_RATE_SAMPLE_INTERVAL``  u32     rate sampling interval
> >    ``ETHTOOL_A_COALESCE_USE_CQE_TX``            bool    timer reset mode, Tx
> >    ``ETHTOOL_A_COALESCE_USE_CQE_RX``            bool    timer reset mode, Rx
> > +  ``ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES``     u32     max aggr packets size, Tx
> > +  ``ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES``    u32     max aggr packets, Tx
> > +  ``ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS``    u32     time (us), aggr pkts, Tx
> >    ===========================================  ======  =======================
>
> Please double check make htmldocs does not generate warnings.
> I think you went outside of the table bounds (further than
> the ==== line)...

Oddly, in my system I don't see any warning related to
ethtool-netlink.rst when doing make htmldocs, I will send anyway a v3
with changes to stay inside the table bounds.

Thanks,
Daniele