netdev - Re: [PATCH net] ip_gre: do not report erspan version on GRE interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202212022202.AFdfAcz4-lkp@intel.com>
Date:   Fri, 2 Dec 2022 22:44:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        "David S . Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        William Tu <u9012063@...il.com>,
        Hangbin Liu <liuhangbin@...il.com>,
        Jianlin Shi <jishi@...hat.com>
Subject: Re: [PATCH net] ip_gre: do not report erspan version on GRE interface

Hi Hangbin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Hangbin-Liu/ip_gre-do-not-report-erspan-version-on-GRE-interface/20221202-155705
patch link:    https://lore.kernel.org/r/20221202075337.2890001-1-liuhangbin%40gmail.com
patch subject: [PATCH net] ip_gre: do not report erspan version on GRE interface
config: x86_64-randconfig-a005
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/682066601692d8f639fa4e50bf32ec89f3fc6b5b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hangbin-Liu/ip_gre-do-not-report-erspan-version-on-GRE-interface/20221202-155705
        git checkout 682066601692d8f639fa4e50bf32ec89f3fc6b5b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/ipv4/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   net/ipv4/ip_gre.c:143:15: warning: variable 'data_len' set but not used [-Wunused-but-set-variable]
           unsigned int data_len = 0;
                        ^
>> net/ipv4/ip_gre.c:1539:9: warning: variable 'o_flags' set but not used [-Wunused-but-set-variable]
           __be16 o_flags = p->o_flags;
                  ^
   2 warnings generated.


vim +/o_flags +1539 net/ipv4/ip_gre.c

  1534	
  1535	static int erspan_fill_info(struct sk_buff *skb, const struct net_device *dev)
  1536	{
  1537		struct ip_tunnel *t = netdev_priv(dev);
  1538		struct ip_tunnel_parm *p = &t->parms;
> 1539		__be16 o_flags = p->o_flags;
  1540	
  1541		if (t->erspan_ver <= 2) {
  1542			if (t->erspan_ver != 0 && !t->collect_md)
  1543				o_flags |= TUNNEL_KEY;
  1544	
  1545			if (nla_put_u8(skb, IFLA_GRE_ERSPAN_VER, t->erspan_ver))
  1546				goto nla_put_failure;
  1547	
  1548			if (t->erspan_ver == 1) {
  1549				if (nla_put_u32(skb, IFLA_GRE_ERSPAN_INDEX, t->index))
  1550					goto nla_put_failure;
  1551			} else if (t->erspan_ver == 2) {
  1552				if (nla_put_u8(skb, IFLA_GRE_ERSPAN_DIR, t->dir))
  1553					goto nla_put_failure;
  1554				if (nla_put_u16(skb, IFLA_GRE_ERSPAN_HWID, t->hwid))
  1555					goto nla_put_failure;
  1556			}
  1557		}
  1558	
  1559		return ipgre_fill_info(skb, dev);
  1560	
  1561	nla_put_failure:
  1562		return -EMSGSIZE;
  1563	}
  1564	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (141277 bytes)