netdev - Re: [PATCH v2] wifi: brcmfmac: Fix error return code in brcmf_sdio_download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2fef52d-3e93-8489-f4f0-6d67d9f15ba1@broadcom.com>
Date:   Fri, 2 Dec 2022 20:13:57 +0100
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Wang Yufen <wangyufen@...wei.com>, aspriel@...il.com,
        franky.lin@...adcom.com, hante.meuleman@...adcom.com,
        kvalo@...nel.org, davem@...emloft.net
Cc:     linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
        arend@...adcom.com
Subject: Re: [PATCH v2] wifi: brcmfmac: Fix error return code in
 brcmf_sdio_download_firmware()

On 12/2/2022 6:35 AM, Wang Yufen wrote:
> Fix to return a negative error code instead of 0 when
> brcmf_chip_set_active() fails. In addition, change the return
> value for brcmf_pcie_exit_download_state() to keep consistent.
> 
> Fixes: d380ebc9b6fb ("brcmfmac: rename chip download functions")
Reviewed-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Wang Yufen <wangyufen@...wei.com>
> ---
> v2: change the error code from EINVAL to EIO, as Arend suggessted

Thanks.

>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)