netdev - [PATCH net-next 0/2] ptp: Introduce .getfine callback to ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221202201528.26634-1-rrameshbabu@nvidia.com>
Date:   Fri,  2 Dec 2022 12:15:27 -0800
From:   Rahul Rameshbabu <rrameshbabu@...dia.com>
To:     Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Richard Cochran <richardcochran@...il.com>,
        Rahul Rameshbabu <rrameshbabu@...dia.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Aya Levin <ayal@...dia.com>, Gal Pressman <gal@...dia.com>
Cc:     netdev@...r.kernel.org
Subject: [PATCH net-next 0/2] ptp: Introduce .getfine callback to ptp_clock_info

The current state of the ptp driver provides the ability to query the frequency
of the ptp clock device by caching the frequency values used in previous
adjustments done through the ptp driver. This works great when the ptp driver is
the only means for changing the clock frequency. However, some devices support
ways to adjust the frequency outside the ptp driver stack. When this occurs, the
ptp cached value is inaccurate. Also, if the device for some reason does not
start with a frequency of zero, the initial frequency queried before the first
frequency adjustment would be inaccurate.

The changes proposed enable a callback that various drivers can implement to
provide the frequency, in units of scaled ppm, of the ptp clock. When the
callback is implemented, it will be called to provide the frequency value
instead of the cached dialed_frequency value.

There are cases in linuxptp usage where the caching of the frequency has proven
to be inadequate. One example was the case where concurrent ptp4l processes
adjust frequency, but the cached frequency values in the ptp4l processes are
stale. Permitting implementers the ability to provide the frequency would
resolve issues involving stale frequency values due to changes occurring outside
the ptp driver stack.

https://sourceforge.net/p/linuxptp/mailman/message/37720193/

Signed-off-by: Rahul Rameshbabu <rrameshbabu@...dia.com>

Rahul Rameshbabu (2):
  ptp: Add .getfine function to support reporting frequency offset from
    hardware
  net/mlx5: Implement ptp_clock_info .getfine function

 .../ethernet/mellanox/mlx5/core/lib/clock.c   | 35 +++++++++++++++++++
 drivers/ptp/ptp_clock.c                       | 18 +++++++++-
 include/linux/ptp_clock_kernel.h              |  6 ++++
 3 files changed, 58 insertions(+), 1 deletion(-)

-- 
2.36.2