netdev - Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff01f296-f3bb-4fdf-d57f-8dd14f1b61d2@ieee.org>
Date:   Fri, 2 Dec 2022 16:20:16 -0600
From:   Alex Elder <elder@...e.org>
To:     ye.xingchen@....com.cn, davem@...emloft.net
Cc:     elder@...nel.org, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()

On 12/2/22 2:42 AM, ye.xingchen@....com.cn wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.

The buffer passed is non-null and the existing code properly
limits the buffer to PAGE_SIZE.

But... OK.

Reviewed-by: Alex Elder <elder@...aro.org>

> 
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>   drivers/net/ipa/ipa_sysfs.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c
> index 5cbc15a971f9..14bd2f903045 100644
> --- a/drivers/net/ipa/ipa_sysfs.c
> +++ b/drivers/net/ipa/ipa_sysfs.c
> @@ -46,7 +46,7 @@ version_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct ipa *ipa = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_version_string(ipa));
> +	return sysfs_emit(buf, "%s\n", ipa_version_string(ipa));
>   }
> 
>   static DEVICE_ATTR_RO(version);
> @@ -70,7 +70,7 @@ static ssize_t rx_offload_show(struct device *dev,
>   {
>   	struct ipa *ipa = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa));
> +	return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa));
>   }
> 
>   static DEVICE_ATTR_RO(rx_offload);
> @@ -80,7 +80,7 @@ static ssize_t tx_offload_show(struct device *dev,
>   {
>   	struct ipa *ipa = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa));
> +	return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa));
>   }
> 
>   static DEVICE_ATTR_RO(tx_offload);