lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 02 Dec 2022 23:50:18 +0100 From: Michael Walle <michael@...le.cc> To: Andrew Lunn <andrew@...n.ch> Cc: Xu Liang <lxu@...linear.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH net-next v1 3/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings Am 2022-12-02 19:31, schrieb Andrew Lunn: > On Fri, Dec 02, 2022 at 04:12:03PM +0100, Michael Walle wrote: >> Add the device tree bindings for the MaxLinear GPY2xx PHYs. >> >> Signed-off-by: Michael Walle <michael@...le.cc> >> --- >> >> Is the filename ok? I was unsure because that flag is only for the >> GPY215 >> for now. But it might also apply to others. Also there is no >> compatible >> string, so.. >> >> .../bindings/net/maxlinear,gpy2xx.yaml | 47 >> +++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml >> b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml >> new file mode 100644 >> index 000000000000..d71fa9de2b64 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml >> @@ -0,0 +1,47 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/maxlinear,gpy2xx.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MaxLinear GPY2xx PHY >> + >> +maintainers: >> + - Andrew Lunn <andrew@...n.ch> >> + - Michael Walle <michael@...le.cc> >> + >> +allOf: >> + - $ref: ethernet-phy.yaml# >> + >> +properties: >> + maxlinear,use-broken-interrupts: >> + description: | >> + Interrupts are broken on some GPY2xx PHYs in that they keep the >> + interrupt line asserted even after the interrupt status >> register is >> + cleared. Thus it is blocking the interrupt line which is >> usually bad >> + for shared lines. By default interrupts are disabled for this >> PHY and >> + polling mode is used. If one can live with the consequences, >> this >> + property can be used to enable interrupt handling. >> + >> + Affected PHYs (as far as known) are GPY215B and GPY215C. >> + type: boolean >> + >> +dependencies: >> + maxlinear,use-broken-interrupts: [ interrupts ] >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + ethernet { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + ethernet-phy@0 { >> + reg = <0>; >> + interrupts-extended = <&intc 0>; >> + maxlinear,use-broken-interrupts; >> + }; >> + }; > > I'm wondering if we want this in the example. We probably don't want > people to use this property by accident, i.e. copy/paste without > reading the rest of the document. This will becomes a bigger problem > if more properties are added, RGMII delays etc. > > So maybe just skip the example? I agree. Let's wait what the device tree maintainers say. -michael
Powered by blists - more mailing lists