netdev - Re: [PATCH net] selftests: rtnetlink: correct xfrm policy rule in kci_test_ipsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Dec 2022 10:06:56 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, shuah@...nel.org, shannon.nelson@...cle.com,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net] selftests: rtnetlink: correct xfrm policy rule in
 kci_test_ipsec_offload

On Thu, Dec 01, 2022 at 04:22:46PM +0800, Zhengchao Shao wrote:
> When testing in kci_test_ipsec_offload, srcip is configured as $dstip,
> it should add xfrm policy rule in instead of out.
> The test result of this patch is as follows:
> PASS: ipsec_offload
> 
> Fixes: 2766a11161cc ("selftests: rtnetlink: add ipsec offload API test")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  tools/testing/selftests/net/rtnetlink.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index 0900c5438fbb..275491be3da2 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -782,7 +782,7 @@ kci_test_ipsec_offload()
>  	    tmpl proto esp src $srcip dst $dstip spi 9 \
>  	    mode transport reqid 42
>  	check_err $?
> -	ip x p add dir out src $dstip/24 dst $srcip/24 \
> +	ip x p add dir in src $dstip/24 dst $srcip/24 \
>  	    tmpl proto esp src $dstip dst $srcip spi 9 \
>  	    mode transport reqid 42
>  	check_err $?
> -- 
> 2.34.1
>

Acked-by: Hangbin Liu <liuhangbin@...il.com>