netdev - Re: [PATCHv2 net] ip_gre: do not report erspan version on GRE interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALDO+SbuAAsPHRq=KHh1Z_+DquwdDVJaUqXozGgzoixOUddJNA@mail.gmail.com>
Date:   Sat, 3 Dec 2022 07:25:50 -0800
From:   William Tu <u9012063@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Jianlin Shi <jishi@...hat.com>
Subject: Re: [PATCHv2 net] ip_gre: do not report erspan version on GRE interface

On Fri, Dec 2, 2022 at 7:29 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> Although the type I ERSPAN is based on the barebones IP + GRE
> encapsulation and no extra ERSPAN header. Report erspan version on GRE
> interface looks unreasonable. Fix this by separating the erspan and gre
> fill info.

Thanks, it's true that current code when using GRE, we will report ERSPAN type,
which is not necessary.

>
> IPv6 GRE does not have this info as IPv6 only supports erspan version
> 1 and 2.

I checked the ipv6 GRE, and it doesn't report because we're checking
in ip6gre_fill_info
        if (p->erspan_ver == 1 || p->erspan_ver == 2) {
So it's indeed ok for IPv6 GRE.

>
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Fixes: f989d546a2d5 ("erspan: Add type I version 0 support.")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Acked-by: William Tu <u9012063@...il.com>