lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Dec 2022 11:02:45 -0700 From: David Ahern <dsahern@...nel.org> To: Jacob Keller <jacob.e.keller@...el.com> Cc: netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us> Subject: Re: [PATCH iproute2-next] devlink: support direct region read requests > diff --git a/devlink/devlink.c b/devlink/devlink.c > index 8aefa101b2f8..5057b09505ef 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -8535,11 +8535,15 @@ static int cmd_region_read(struct dl *dl) > int err; > > err = dl_argv_parse(dl, DL_OPT_HANDLE_REGION | DL_OPT_REGION_ADDRESS | > - DL_OPT_REGION_LENGTH | DL_OPT_REGION_SNAPSHOT_ID, > - 0); > + DL_OPT_REGION_LENGTH, > + DL_OPT_REGION_SNAPSHOT_ID); > if (err) > return err; > > + /* If user didn't provide a snapshot id, perform a direct read */ > + if (!(dl->opts.present & DL_OPT_REGION_SNAPSHOT_ID)) > + mnl_attr_put(nlh, DEVLINK_ATTR_REGION_DIRECT, 0, NULL); > + > nlh = mnlu_gen_socket_cmd_prepare(&dl->nlg, DEVLINK_CMD_REGION_READ, > NLM_F_REQUEST | NLM_F_ACK | NLM_F_DUMP); > > > base-commit: 2ed09c3bf8aca185b2f3eb369ae435503f9b9826 > -- > 2.38.1.420.g319605f8f00e > This introduces a compile warning: devlink.c: In function ‘dl_cmd’: devlink.c:8613:3: warning: ‘nlh’ may be used uninitialized in this function [-Wmaybe-uninitialized] 8613 | mnl_attr_put(nlh, DEVLINK_ATTR_REGION_DIRECT, 0, NULL); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ devlink.c:8602:19: note: ‘nlh’ was declared here and always add maintainers to iproute2 patches.
Powered by blists - more mailing lists