netdev - Re: ip_forward notification for driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4xizqncq1JTvNMu@shredder>
Date:   Sun, 4 Dec 2022 11:05:18 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Leonid Komaryanskiy <lkomaryanskiy@...il.com>
Cc:     netdev@...r.kernel.org, dmytro_firsov@...m.com, petrm@...dia.com,
        davem@...emloft.net, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Subject: Re: ip_forward notification for driver

On Thu, Dec 01, 2022 at 05:21:10PM +0200, Leonid Komaryanskiy wrote:
> We checked netevents (NETEVENT_IPV4_MPATH_HASH_UPDATE and
> NETEVENT_IPV4_FWD_UPDATE_PRIORITY_UPDATE) but unfortunately, netevents
> notifier doesn't trigger at all in case of changing value in
> /proc/sys/net/ipv4/ip_forward. We see, that these events come in the
> case of modifying /proc/sys/net/ipv4/fib_multipath_hash_policy, but
> not for ip_forward. Shell we prepare an upstream patch with notifier
> for ip_forward modify netevent?

I believe this is the correct interface to use for this notification,
but if you are going to submit such a patch, then it needs to be
submitted together with a patch for a driver that listens to the event
an acts upon it. New APIs without an upstream user are not allowed.
Also, please make sure you add a test under
tools/testing/selftests/net/forwarding/.

P.S. Please avoid top-posting as explained here:
https://docs.kernel.org/process/2.Process.html#mailing-lists