netdev - Re: [patch net-next RFC 0/7] devlink: make sure devlink port registers/unregisters only for registered instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4yGCTMyV2bdD+05@unreal>
Date:   Sun, 4 Dec 2022 13:35:37 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, yangyingliang@...wei.com
Subject: Re: [patch net-next RFC 0/7] devlink: make sure devlink port
 registers/unregisters only for registered instance

On Thu, Dec 01, 2022 at 05:46:01PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>

<...>

> Jiri Pirko (7):
>   devlink: Reorder devlink_port_register/unregister() calls to be done
>     when devlink is registered
>   netdevsim: Reorder devl_port_register/unregister() calls to be done
>     when devlink is registered
>   mlxsw: Reorder devl_port_register/unregister() calls to be done when
>     devlink is registered
>   nfp: Reorder devl_port_register/unregister() calls to be done when
>     devlink is registered
>   mlx4: Reorder devl_port_register/unregister() calls to be done when
>     devlink is registered
>   mlx5: Reorder devl_port_register/unregister() calls to be done when
>     devlink is registered
>   devlink: assert if devl_port_register/unregister() is called on
>     unregistered devlink instance

Thanks, it is more clear now what you wanted.
Everything here looks ok, but can you please find better titles for the
commit messages? They are too long.

Not related to the series, but spotted during the code review,
It will be nice if you can get rid of devlink_port->registered and rely
xarray marks for that. It will be cleaner and aligned with devlink object.

Thanks