netdev - Re: [patch net-next RFC 7/7] devlink: assert if devl_port_register/unregister() is called on unregistered devlink instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y43A5nQYWwQpt6v2@nanopsycho>
Date:   Mon, 5 Dec 2022 10:59:02 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, yangyingliang@...wei.com
Subject: Re: [patch net-next RFC 7/7] devlink: assert if
 devl_port_register/unregister() is called on unregistered devlink instance

Sun, Dec 04, 2022 at 12:40:09PM CET, leon@...nel.org wrote:
>On Thu, Dec 01, 2022 at 05:46:08PM +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...dia.com>
>> 
>> Now when all drivers do call devl_port_register/unregister() withing the
>> time frame during which the devlink is registered, put and assertion to
>> the functions to check that and avoid going back.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...dia.com>
>> ---
>>  net/core/devlink.c | 2 ++
>>  1 file changed, 2 insertions(+)
>
>You also need to remove delayed notifications from devlink_notify_register()
>
>   9862         xa_for_each(&devlink->ports, port_index, devlink_port)
>   9863                 devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW);
>

Correct, I forgot.

>Thanks