netdev - Re: [PATCH net] xen/netback: don't call kfree_skb() under spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef302bc7-5c55-2bb5-d159-27fd6a8ed9df@xen.org>
Date:   Mon, 5 Dec 2022 14:38:35 +0000
From:   Paul Durrant <xadimgnik@...il.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        xen-devel@...ts.xenproject.org, netdev@...r.kernel.org
Cc:     wei.liu@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, jbeulich@...e.com,
        jgross@...e.com
Subject: Re: [PATCH net] xen/netback: don't call kfree_skb() under
 spin_lock_irqsave()

On 05/12/2022 14:13, Yang Yingliang wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with interrupts being disabled. So replace kfree_skb()
> with dev_kfree_skb_irq() under spin_lock_irqsave().
> 
> Fixes: be81992f9086 ("xen/netback: don't queue unlimited number of packages")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Reviewed-by: Paul Durrant <paul@....org>