netdev - Re: [PATCH bpf v2] bpf: Add dummy type reference to nf_conn__

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167020921530.5137.9042058313238429858.git-patchwork-notify@kernel.org>
Date:   Mon, 05 Dec 2022 03:00:15 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Toke Høiland-Jørgensen <toke@...hat.com>@ci.codeaurora.org
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        martin.lau@...ux.dev, song@...nel.org, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com,
        haoluo@...gle.com, jolsa@...nel.org, davem@...emloft.net,
        kuba@...nel.org, hawk@...nel.org, lorenzo@...nel.org,
        memxor@...il.com, jbenc@...hat.com, edumazet@...gle.com,
        pabeni@...hat.com, bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf v2] bpf: Add dummy type reference to nf_conn___init to fix
 type deduplication

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Thu,  1 Dec 2022 13:39:39 +0100 you wrote:
> The bpf_ct_set_nat_info() kfunc is defined in the nf_nat.ko module, and
> takes as a parameter the nf_conn___init struct, which is allocated through
> the bpf_xdp_ct_alloc() helper defined in the nf_conntrack.ko module.
> However, because kernel modules can't deduplicate BTF types between each
> other, and the nf_conn___init struct is not referenced anywhere in vmlinux
> BTF, this leads to two distinct BTF IDs for the same type (one in each
> module). This confuses the verifier, as described here:
> 
> [...]

Here is the summary with links:
  - [bpf,v2] bpf: Add dummy type reference to nf_conn___init to fix type deduplication
    https://git.kernel.org/bpf/bpf-next/c/578ce69ffda4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html