netdev - Re: [PATCH net] team: prevent ipv6 link local address on port devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221205103905.1b2fa96a@hermes.local>
Date:   Mon, 5 Dec 2022 10:39:05 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net,
        kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Jiri Pirko <jiri@...nulli.us>,
        LiLiang <liali@...hat.com>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>
Subject: Re: [PATCH net] team: prevent ipv6 link local address on port
 devices

On Mon,  5 Dec 2022 12:46:05 -0500
Xin Long <lucien.xin@...il.com> wrote:

> The similar fix from commit c2edacf80e15 ("bonding / ipv6: no addrconf
> for slaves separately from master") is also needed in Team. Otherwise,
> DAD and RS packets to be sent from the slaves in turn can confuse the
> switches and cause them to incorrectly update their forwarding tables
> as Liang noticed in the test with activebackup mode.
> 
> Note that the patch also sets IFF_MASTER flag for Team dev accordingly
> while IFF_SLAVE flag is set for port devs. Although IFF_MASTER flag is
> not really used in Team, it's good to show in 'ip link':
> 
>   eth1: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP>
>   team0: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP>
> 
> Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device")
> Reported-by: LiLiang <liali@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

The failover device probably needs the same changes.
Does anyone use the failover network device? Looks like KVM never got support for it.