[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <167027652411.2674430.15313904791062984653.robh@kernel.org>
Date: Mon, 5 Dec 2022 15:42:10 -0600
From: Rob Herring <robh@...nel.org>
To: Colin Foster <colin.foster@...advantage.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Marek Vasut <marex@...x.de>, UNGLinuxDriver@...rochip.com,
John Crispin <john@...ozen.org>, linux-kernel@...r.kernel.org,
Alvin Šipraga <alsi@...g-olufsen.dk>,
Landen Chao <Landen.Chao@...iatek.com>,
Paolo Abeni <pabeni@...hat.com>,
linux-mediatek@...ts.infradead.org,
Woojung Huh <woojung.huh@...rochip.com>,
"David S. Miller" <davem@...emloft.net>,
nç ÜNAL <arinc.unal@...nc9.com>,
Rob Herring <robh+dt@...nel.org>,
linux-renesas-soc@...r.kernel.org,
Sean Wang <sean.wang@...iatek.com>,
Linus Walleij <linus.walleij@...aro.org>,
Claudiu Manoil <claudiu.manoil@....com>,
Eric Dumazet <edumazet@...gle.com>, devicetree@...r.kernel.org,
Kurt Kanzenbach <kurt@...utronix.de>,
linux-arm-kernel@...ts.infradead.org,
Florian Fainelli <f.fainelli@...il.com>,
", DENG Qingfang" <dqfext@...il.com>, Andrew Lunn <andrew@...n.ch>,
George McCollister <george.mccollister@...il.com>,
Jakub Kicinski <kuba@...nel.org>,
Vivien Didelot <vivien.didelot@...il.com>,
Matthias Brugger <matthias.bgg@...il.com>,
netdev@...r.kernel.org, Vladimir Oltean <olteanv@...il.com>,
Clément Léger <clement.leger@...tlin.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH v4 net-next 3/9] dt-bindings: net: dsa: utilize base
definitions for standard dsa switches
On Fri, 02 Dec 2022 12:45:53 -0800, Colin Foster wrote:
> DSA switches can fall into one of two categories: switches where all ports
> follow standard '(ethernet-)?port' properties, and switches that have
> additional properties for the ports.
>
> The scenario where DSA ports are all standardized can be handled by
> swtiches with a reference to the new 'dsa.yaml#/$defs/ethernet-ports'.
>
> The scenario where DSA ports require additional properties can reference
> '$dsa.yaml#' directly. This will allow switches to reference these standard
> defitions of the DSA switch, but add additional properties under the port
> nodes.
>
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Colin Foster <colin.foster@...advantage.com>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Acked-by: Alvin Šipraga <alsi@...g-olufsen.dk> # realtek
> ---
>
> v3 -> v4
> * Rename "$defs/base" to "$defs/ethernet-ports" to avoid implication of a
> "base class" and fix commit message accordingly
> * Add the following to the common etherent-ports node:
> "additionalProperties: false"
> "#address-cells" property
> "#size-cells" property
> * Fix "etherenet-ports@[0-9]+" to correctly be "ethernet-port@[0-9]+"
> * Remove unnecessary newline
> * Apply changes to mediatek,mt7530.yaml that were previously in a separate patch
> * Add Reviewed and Acked tags
>
> v3
> * New patch
>
> ---
> .../bindings/net/dsa/arrow,xrs700x.yaml | 2 +-
> .../devicetree/bindings/net/dsa/brcm,b53.yaml | 2 +-
> .../devicetree/bindings/net/dsa/dsa.yaml | 25 ++++++++++++++++---
> .../net/dsa/hirschmann,hellcreek.yaml | 2 +-
> .../bindings/net/dsa/mediatek,mt7530.yaml | 16 +++---------
> .../bindings/net/dsa/microchip,ksz.yaml | 2 +-
> .../bindings/net/dsa/microchip,lan937x.yaml | 2 +-
> .../bindings/net/dsa/mscc,ocelot.yaml | 2 +-
> .../bindings/net/dsa/nxp,sja1105.yaml | 2 +-
> .../devicetree/bindings/net/dsa/realtek.yaml | 2 +-
> .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 2 +-
> 11 files changed, 35 insertions(+), 24 deletions(-)
>
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists