netdev - Re: [PATCH net-next V3 7/8] devlink: Expose port function commands to control migratable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e3deb3a-a3fd-d954-3b6f-8d2547e036d5@amd.com>
Date:   Mon, 5 Dec 2022 15:37:44 -0800
From:   Shannon Nelson <shnelson@....com>
To:     Shay Drory <shayd@...dia.com>, netdev@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net
Cc:     danielj@...dia.com, yishaih@...dia.com, jiri@...dia.com,
        saeedm@...dia.com, parav@...dia.com
Subject: Re: [PATCH net-next V3 7/8] devlink: Expose port function commands to
 control migratable

On 12/4/22 6:16 AM, Shay Drory wrote:
> Expose port function commands to enable / disable migratable
> capability, this is used to set the port function as migratable.

Since most or the devlink attributes, parameters, etc are named as nouns 
or verbs (e.g. roce, running, rate, err_count, enable_sriov, etc), 
seeing this term in an adjective form is a bit jarring.  This may seem 
like a picky thing, but can we use "migrate" or "migration" throughout 
this patch rather than "migratable"?

> 
> Live migration is the process of transferring a live virtual machine
> from one physical host to another without disrupting its normal
> operation.
> 
> In order for a VM to be able to perform LM, all the VM components must
> be able to perform migration. e.g.: to be migratable.
> In order for VF to be migratable, VF must be bound to VFIO driver with
> migration support.
> 
> When migratable capability is enable for a function of the port, the

s/enable/enabled/



> 
> diff --git a/include/net/devlink.h b/include/net/devlink.h
> index 20306fb8a1d9..fdb5e8da33ce 100644
> --- a/include/net/devlink.h
> +++ b/include/net/devlink.h
> @@ -1470,6 +1470,27 @@ struct devlink_ops {
>          int (*port_function_roce_set)(struct devlink_port *devlink_port,
>                                        bool enable,
>                                        struct netlink_ext_ack *extack);
> +       /**
> +        * @port_function_mig_get: Port function's migratable get function.

I would prefer to see 'mig' spelled out as 'migration'

sln