netdev - Re: [EXT] Re: [PATCH net-next v2 2/9] octeon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y42nerLmNeAIn5w9@unreal>
Date:   Mon, 5 Dec 2022 10:10:34 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Veerasenareddy Burru <vburru@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Liron Himi <lironh@...vell.com>,
        Abhijit Ayarekar <aayarekar@...vell.com>,
        Sathesh B Edara <sedara@...vell.com>,
        Satananda Burla <sburla@...vell.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control
 messages

On Mon, Dec 05, 2022 at 04:46:31AM +0000, Veerasenareddy Burru wrote:
> 
> 
> > -----Original Message-----
> > From: Leon Romanovsky <leon@...nel.org>
> > Sent: Thursday, December 1, 2022 12:11 AM
> > To: Veerasenareddy Burru <vburru@...vell.com>
> > Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Liron Himi
> > <lironh@...vell.com>; Abhijit Ayarekar <aayarekar@...vell.com>; Sathesh
> > B Edara <sedara@...vell.com>; Satananda Burla <sburla@...vell.com>;
> > linux-doc@...r.kernel.org; David S. Miller <davem@...emloft.net>; Eric
> > Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> > Paolo Abeni <pabeni@...hat.com>
> > Subject: Re: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control
> > messages
> > 
> > On Wed, Nov 30, 2022 at 03:44:30PM +0000, Veerasenareddy Burru wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Leon Romanovsky <leon@...nel.org>
> > > > Sent: Wednesday, November 30, 2022 1:30 AM
> > > > To: Veerasenareddy Burru <vburru@...vell.com>
> > > > Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Liron Himi
> > > > <lironh@...vell.com>; Abhijit Ayarekar <aayarekar@...vell.com>;
> > > > Sathesh B Edara <sedara@...vell.com>; Satananda Burla
> > > > <sburla@...vell.com>; linux-doc@...r.kernel.org; David S. Miller
> > > > <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>;
> > Jakub
> > > > Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>
> > > > Subject: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for
> > > > control messages
> > > >
> > > > External Email
> > > >
> > > > --------------------------------------------------------------------
> > > > -- On Tue, Nov 29, 2022 at 05:09:25AM -0800, Veerasenareddy Burru
> > > > wrote:
> > > > > Poll for control messages until interrupts are enabled.
> > > > > All the interrupts are enabled in ndo_open().
> > > >
> > > > So what are you saying if I have your device and didn't enable
> > > > network device, you will poll forever?
> > > Yes, Leon. It will poll periodically until network interface is enabled.
> > 
> > I don't know if it is acceptable behaviour in netdev, but it doesn't sound right
> > to me. What type of control messages will be sent by FW, which PF should
> > listen to them?
> > 
> 
> These messages include periodic keep alive (heartbeat) messages from FW and control messages from VFs.
> Every PF will be listening for its own control messages.

@netdev, as I said, I don't know if it is valid behaviour in netdev.
Can you please comment?

Thanks