netdev - Re: [PATCH net-next v7] ethtool: add netlink based get rss support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221205173324.072b21da@kernel.org>
Date:   Mon, 5 Dec 2022 17:33:24 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Sudheer Mogilappagari <sudheer.mogilappagari@...el.com>,
        netdev@...r.kernel.org, mkubecek@...e.cz, andrew@...n.ch,
        corbet@....net, sridhar.samudrala@...el.com,
        anthony.l.nguyen@...el.com
Subject: Re: [PATCH net-next v7] ethtool: add netlink based get rss support

On Mon, 5 Dec 2022 09:45:07 +0200 Leon Romanovsky wrote:
> > Conversion to netlink stands on its own.  
> 
> It doesn't answer on my question. The answer is "we do, just because we
> can" is nice but doesn't remove my worries that such "future" extension
> will work with real future feature.

By that logic we should have not merged 90% of netlink ethtool patches,
and I don't think we have had any major backward compat problems.

> From my experience, many UAPI designs without real use case in hand
> will require adaptions and won't work out-of-box.

Which is why this patch has been cut down to the bare minimum.
See the reviews for previous 6 versions.

> IMHO, it is the same sin as premature optimization.

Your feedback has been registered.