netdev - Re: [PATCH net v2] net: thunderbolt: fix memory leak in tbnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y48Nf4OkBbaVgw4C@nanopsycho>
Date:   Tue, 6 Dec 2022 10:38:07 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, michael.jamet@...el.com,
        mika.westerberg@...ux.intel.com, YehezkelShB@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net v2] net: thunderbolt: fix memory leak in tbnet_open()

Tue, Dec 06, 2022 at 02:06:46AM CET, shaozhengchao@...wei.com wrote:
>When tb_ring_alloc_rx() failed in tbnet_open(), it doesn't free ida.

You should be imperative to the codebase in your patch descriptions.

The code fix looks okay.

>
>Fixes: 180b0689425c ("thunderbolt: Allow multiple DMA tunnels over a single XDomain connection")
>Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>---
>v2: move release ida before free tx_ring
>---
> drivers/net/thunderbolt.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c
>index a52ee2bf5575..6312f67f260e 100644
>--- a/drivers/net/thunderbolt.c
>+++ b/drivers/net/thunderbolt.c
>@@ -914,6 +914,7 @@ static int tbnet_open(struct net_device *dev)
> 				eof_mask, tbnet_start_poll, net);
> 	if (!ring) {
> 		netdev_err(dev, "failed to allocate Rx ring\n");
>+		tb_xdomain_release_out_hopid(xd, hopid);
> 		tb_ring_free(net->tx_ring.ring);
> 		net->tx_ring.ring = NULL;
> 		return -ENOMEM;
>-- 
>2.34.1
>