netdev - Re: [PATCH net] team: prevent ipv6 link local address on port devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_e6dFT6L69g63FOu=uE7b48rubaYOBL0RDTmKRUBFDCjw@mail.gmail.com>
Date:   Tue, 6 Dec 2022 08:32:25 -0500
From:   Xin Long <lucien.xin@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net,
        kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, LiLiang <liali@...hat.com>
Subject: Re: [PATCH net] team: prevent ipv6 link local address on port devices

On Tue, Dec 6, 2022 at 3:05 AM Jiri Pirko <jiri@...nulli.us> wrote:
>
> Mon, Dec 05, 2022 at 06:46:05PM CET, lucien.xin@...il.com wrote:
> >The similar fix from commit c2edacf80e15 ("bonding / ipv6: no addrconf
> >for slaves separately from master") is also needed in Team. Otherwise,
> >DAD and RS packets to be sent from the slaves in turn can confuse the
> >switches and cause them to incorrectly update their forwarding tables
> >as Liang noticed in the test with activebackup mode.
> >
> >Note that the patch also sets IFF_MASTER flag for Team dev accordingly
> >while IFF_SLAVE flag is set for port devs. Although IFF_MASTER flag is
> >not really used in Team, it's good to show in 'ip link':
> >
> >  eth1: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP>
> >  team0: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP>
> >
> >Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device")
> >Reported-by: LiLiang <liali@...hat.com>
> >Signed-off-by: Xin Long <lucien.xin@...il.com>
>
> Nack. Please don't do this. IFF_MASTER and IFF_SLAVE are historical
> flags used by bonding and eql. Should not be used for other devices.
I see. I was wondering why it was not used in Team at the beginning. :)

>
> addrconf_addr_gen() should not check IFF_SLAVE. It should use:
> netif_is_lag_port() and netif_is_failover_slave() helpers.
netif_is_failover_slave() should be able to address Stephen's concern
on failover network device.

Will repost, Thanks.