netdev - Re: [PATCH net] bonding: get correct NA dest address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7be4ae2-f55e-0277-3c1c-cecad5cc9262@redhat.com>
Date:   Tue, 6 Dec 2022 10:42:35 -0500
From:   Jonathan Toppins <jtoppins@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] bonding: get correct NA dest address

On 12/5/22 22:20, Hangbin Liu wrote:
> In commit 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving
> IPv6 messages"), there is a copy/paste issue for NA daddr. I found that
> in my testing and fixed it in my local branch. But I forgot to re-format
> the patch and sent the wrong mail.
> 
> Fix it by reading the correct dest address.
> 
> Fixes: 4d633d1b468b ("bonding: fix ICMPv6 header handling when receiving IPv6 messages")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Acked-by: Jonathan Toppins <jtoppins@...hat.com>

> ---
>   drivers/net/bonding/bond_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index f298b9b3eb77..b9a882f182d2 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3247,7 +3247,7 @@ static int bond_na_rcv(const struct sk_buff *skb, struct bonding *bond,
>   		goto out;
>   
>   	saddr = &combined->ip6.saddr;
> -	daddr = &combined->ip6.saddr;
> +	daddr = &combined->ip6.daddr;
>   
>   	slave_dbg(bond->dev, slave->dev, "%s: %s/%d av %d sv %d sip %pI6c tip %pI6c\n",
>   		  __func__, slave->dev->name, bond_slave_state(slave),