netdev - Re: [PATCH net] ethernet: s2io: don't call dev_kfree_skb() under spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKxd7zoeD4GVHcwD62ZzY8bk6NZUYd9c7kdUQc9K_iTfA@mail.gmail.com>
Date:   Tue, 6 Dec 2022 17:12:59 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     netdev@...r.kernel.org, jdmason@...zu.us, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net] ethernet: s2io: don't call dev_kfree_skb() under spin_lock_irqsave()

On Tue, Dec 6, 2022 at 4:53 PM Yang Yingliang <yangyingliang@...wei.com> wrote:
>
> It is not allowed to call consume_skb() from hardware interrupt context
> or with interrupts being disabled. So replace dev_kfree_skb() with
> dev_consume_skb_irq() under spin_lock_irqsave().
>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

You forgot a Fixes: tag