netdev - RE: [PATCH net-next v2] macsec: Add support for IFLA_MACSEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR12MB6353D1AC508A6AD193E4A629AB1B9@IA1PR12MB6353.namprd12.prod.outlook.com>
Date:   Tue, 6 Dec 2022 21:33:34 +0000
From:   Emeel Hakim <ehakim@...dia.com>
To:     Sabrina Dubroca <sd@...asysnail.net>, Jiri Pirko <jiri@...nulli.us>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Raed Salem <raeds@...dia.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v2] macsec: Add support for IFLA_MACSEC_OFFLOAD
 in the netlink layer



> -----Original Message-----
> From: Sabrina Dubroca <sd@...asysnail.net>
> Sent: Tuesday, 6 December 2022 18:11
> To: Jiri Pirko <jiri@...nulli.us>
> Cc: Emeel Hakim <ehakim@...dia.com>; linux-kernel@...r.kernel.org; Raed
> Salem <raeds@...dia.com>; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; netdev@...r.kernel.org
> Subject: Re: [PATCH net-next v2] macsec: Add support for IFLA_MACSEC_OFFLOAD
> in the netlink layer
> 
> External email: Use caution opening links or attachments
> 
> 
> 2022-12-06, 14:35:23 +0100, Jiri Pirko wrote:
> > Tue, Dec 06, 2022 at 01:31:54PM CET, ehakim@...dia.com wrote:
> > >> Tue, Dec 06, 2022 at 09:57:57AM CET, ehakim@...dia.com wrote:
> > >> >From: Emeel Hakim <ehakim@...dia.com>
> > >> >
> > >> >This adds support for configuring Macsec offload through the
> > >>
> > >> Tell the codebase what to do. Be imperative in your patch
> > >> descriptions so it is clear what are the intensions of the patch.
> > >
> > >Ack
> > >
> > >>
> > >>
> > >> >netlink layer by:
> > >> >- Considering IFLA_MACSEC_OFFLOAD in macsec_fill_info.
> > >> >- Handling IFLA_MACSEC_OFFLOAD in macsec_changelink.
> > >> >- Adding IFLA_MACSEC_OFFLOAD to the netlink policy.
> > >> >- Adjusting macsec_get_size.
> > >>
> > >> 4 patches then?
> > >
> > >Ack, I will change the commit message to be imperative and will replace the list
> with a good description.
> > >I still believe it should be a one patch since splitting this could break a bisect
> process.
> >
> > Well, when you split, you have to make sure you don't break bisection,
> > always. Please try to figure that out.
> 
> I think this can be split pretty nicely into 3 patches:
>  - add IFLA_MACSEC_OFFLOAD to macsec_rtnl_policy (probably for net
>    with a Fixes tag on the commit that introduced IFLA_MACSEC_OFFLOAD)
>  - add offload to macsec_fill_info/macsec_get_size
>  - add IFLA_MACSEC_OFFLOAD support to changelink
> 
> The subject of the last patch should also make it clear that it's only adding
> IFLA_MACSEC_OFFLOAD to changelink. As it's written, someone could assume
> there's no support at all via rtnl ops and wonder why this patch isn't doing anything
> to newlink, and whether/why this IFLA_MACSEC_OFFLOAD already exists.

Ack , I will split the patch an send the new patches.

> --
> Sabrina