netdev - Re: [PATCH net] s390/qeth: fix use-after-free in hsci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y5BQctZgtUoYzW92@unreal>
Date:   Wed, 7 Dec 2022 10:36:02 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Alexandra Winter <wintera@...ux.ibm.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>,
        Wenjia Zhang <wenjia@...ux.ibm.com>
Subject: Re: [PATCH net] s390/qeth: fix use-after-free in hsci

On Tue, Dec 06, 2022 at 03:56:14PM +0100, Alexandra Winter wrote:
> KASAN found that addr was dereferenced after br2dev_event_work was freed.

Please add KASAN report to be part of commit message.

Thanks

> 
> Fixes: f7936b7b2663 ("s390/qeth: Update MACs of LEARNING_SYNC device")
> Reported-by: Thorsten Winkler <twinkler@...ux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>
> Reviewed-by: Wenjia Zhang <wenjia@...ux.ibm.com>
> Reviewed-by: Thorsten Winkler <twinkler@...ux.ibm.com>
> ---
>  drivers/s390/net/qeth_l2_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
> index 9dc935886e9f..c6ded3fdd715 100644
> --- a/drivers/s390/net/qeth_l2_main.c
> +++ b/drivers/s390/net/qeth_l2_main.c
> @@ -758,7 +758,6 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
>  	struct list_head *iter;
>  	int err = 0;
>  
> -	kfree(br2dev_event_work);
>  	QETH_CARD_TEXT_(card, 4, "b2dw%04lx", event);
>  	QETH_CARD_TEXT_(card, 4, "ma%012llx", ether_addr_to_u64(addr));
>  
> @@ -815,6 +814,7 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
>  	dev_put(brdev);
>  	dev_put(lsyncdev);
>  	dev_put(dstdev);
> +	kfree(br2dev_event_work);
>  }
>  
>  static int qeth_l2_br2dev_queue_work(struct net_device *brdev,
> -- 
> 2.34.1
>