netdev - Re: [PATCH net v2] drivers: net: qlcnic: Fix potential memory leak in qlcnic_sriov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5BZg4kEl8X05tD2@unreal>
Date:   Wed, 7 Dec 2022 11:14:43 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Yuan Can <yuancan@...wei.com>
Cc:     shshaikh@...vell.com, manishc@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        rajesh.borundia@...gic.com, sucheta.chakraborty@...gic.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net v2] drivers: net: qlcnic: Fix potential memory leak
 in qlcnic_sriov_init()

On Wed, Dec 07, 2022 at 08:54:10AM +0000, Yuan Can wrote:
> If vp alloc failed in qlcnic_sriov_init(), all previously allocated vp
> needs to be freed.
> 
> Fixes: f197a7aa6288 ("qlcnic: VF-PF communication channel implementation")
> Signed-off-by: Yuan Can <yuancan@...wei.com>
> ---
> Changes in v2:
> - free all vp before destroy_workqueue(bc->bc_trans_wq)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>