netdev - Re: [PATCH] xen/netback: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKf6xpu5tCeV4P5TUjDiHfupctwYHsnLUGT+TB5Wxgs9riRQ6A@mail.gmail.com>
Date:   Wed, 7 Dec 2022 08:46:14 -0500
From:   Jason Andryuk <jandryuk@...il.com>
To:     Juergen Gross <jgross@...e.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Wei Liu <wei.liu@...nel.org>, Paul Durrant <paul@....org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH] xen/netback: fix build warning

On Wed, Dec 7, 2022 at 2:24 AM Juergen Gross <jgross@...e.com> wrote:
>
> Commit ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in
> the non-linear area") introduced a (valid) build warning.
>
> Fix it.
>
> Fixes: ad7f402ae4f4 ("xen/netback: Ensure protocol headers don't fall in the non-linear area")
> Signed-off-by: Juergen Gross <jgross@...e.com>

Tested-by: Jason Andryuk <jandryuk@...il.com>

I applied ad7f402ae4f4 to 5.15.y and 5.4.y and it broke networking
with my driver domains.  The frontend failed to DHCP an address and it
didn't look like any packets were getting through.  This patch fixed
networking with 5.15.y and 5.4.y.

I think the commit message is worth expanding that this is more than
just a build warning.

Thanks,
Jason