netdev - Re: [PATCH net v3] net: thunderbolt: fix memory leak in tbnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5CZ0O/CC748/YxE@nanopsycho>
Date:   Wed, 7 Dec 2022 14:49:04 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, michael.jamet@...el.com,
        mika.westerberg@...ux.intel.com, YehezkelShB@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net v3] net: thunderbolt: fix memory leak in tbnet_open()

Wed, Dec 07, 2022 at 02:50:01AM CET, shaozhengchao@...wei.com wrote:
>When tb_ring_alloc_rx() failed in tbnet_open(), ida that allocated in
>tb_xdomain_alloc_out_hopid() is not released. Add
>tb_xdomain_release_out_hopid() to the error path to release ida.
>
>Fixes: 180b0689425c ("thunderbolt: Allow multiple DMA tunnels over a single XDomain connection")
>Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>