netdev - Re: [PATCH net v2] net: plip: don't call kfree_skb/dev_kfree_skb() under spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5CbIW/6LsHGbQg3@nanopsycho>
Date:   Wed, 7 Dec 2022 14:54:41 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net v2] net: plip: don't call kfree_skb/dev_kfree_skb()
 under spin_lock_irq()

Wed, Dec 07, 2022 at 02:53:10AM CET, yangyingliang@...wei.com wrote:
>It is not allowed to call kfree_skb() or consume_skb() from
>hardware interrupt context or with interrupts being disabled.
>So replace kfree_skb/dev_kfree_skb() with dev_kfree_skb_irq()
>and dev_consume_skb_irq() under spin_lock_irq().
>
>Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>

I wonder if anyone is actually using PLIP these days :)