netdev - Re: [PATCH net 2/3] mISDN: hfcpci: don't call dev_kfree_skb() under spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5CqCuW6sHPv+eIg@nanopsycho>
Date:   Wed, 7 Dec 2022 15:58:18 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     netdev@...r.kernel.org, isdn@...ux-pingi.de, davem@...emloft.net
Subject: Re: [PATCH net 2/3] mISDN: hfcpci: don't call dev_kfree_skb() under
 spin_lock_irqsave()

Wed, Dec 07, 2022 at 10:32:38AM CET, yangyingliang@...wei.com wrote:
>It is not allowed to call consume_skb() from hardware interrupt context
>or with interrupts being disabled. So replace dev_kfree_skb() with
>dev_consume_skb_irq() under spin_lock_irqsave().
>
>Fixes: 1700fe1a10dc ("Add mISDN HFC PCI driver")
>Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>