netdev - Re: [PATCH net-next 04/11] sfc: implement vDPA management device operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2022 00:31:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gautam Dawar <gautam.dawar@....com>, linux-net-drivers@....com,
        netdev@...r.kernel.org, jasowang@...hat.com, eperezma@...hat.com
Cc:     oe-kbuild-all@...ts.linux.dev, tanuj.kamde@....com,
        Koushik.Dutta@....com, harpreet.anand@....com,
        Gautam Dawar <gautam.dawar@....com>,
        Edward Cree <ecree.xilinx@...il.com>,
        Martin Habets <habetsm.xilinx@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 04/11] sfc: implement vDPA management device
 operations

Hi Gautam,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Gautam-Dawar/sfc-add-vDPA-support-for-EF100-devices/20221207-230026
patch link:    https://lore.kernel.org/r/20221207145428.31544-5-gautam.dawar%40amd.com
patch subject: [PATCH net-next 04/11] sfc: implement vDPA management device operations
config: ia64-allyesconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ff563410d33798677670893391c1d56ec659d3e3
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gautam-Dawar/sfc-add-vDPA-support-for-EF100-devices/20221207-230026
        git checkout ff563410d33798677670893391c1d56ec659d3e3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/net/ethernet/sfc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/sfc/ef100_vdpa.c: In function 'ef100_vdpa_create':
>> drivers/net/ethernet/sfc/ef100_vdpa.c:109:24: warning: variable 'dev' set but not used [-Wunused-but-set-variable]
     109 |         struct device *dev;
         |                        ^~~


vim +/dev +109 drivers/net/ethernet/sfc/ef100_vdpa.c

   101	
   102	static struct ef100_vdpa_nic *ef100_vdpa_create(struct efx_nic *efx,
   103							const char *dev_name,
   104							enum ef100_vdpa_class dev_type,
   105							const u8 *mac)
   106	{
   107		struct ef100_nic_data *nic_data = efx->nic_data;
   108		struct ef100_vdpa_nic *vdpa_nic;
 > 109		struct device *dev;
   110		int rc;
   111	
   112		nic_data->vdpa_class = dev_type;
   113		vdpa_nic = vdpa_alloc_device(struct ef100_vdpa_nic,
   114					     vdpa_dev, &efx->pci_dev->dev,
   115					     &ef100_vdpa_config_ops,
   116					     1, 1,
   117					     dev_name, false);
   118		if (!vdpa_nic) {
   119			pci_err(efx->pci_dev,
   120				"vDPA device allocation failed for vf: %u\n",
   121				nic_data->vf_index);
   122			nic_data->vdpa_class = EF100_VDPA_CLASS_NONE;
   123			return ERR_PTR(-ENOMEM);
   124		}
   125	
   126		mutex_init(&vdpa_nic->lock);
   127		dev = &vdpa_nic->vdpa_dev.dev;
   128		efx->vdpa_nic = vdpa_nic;
   129		vdpa_nic->vdpa_dev.dma_dev = &efx->pci_dev->dev;
   130		vdpa_nic->vdpa_dev.mdev = efx->mgmt_dev;
   131		vdpa_nic->efx = efx;
   132		vdpa_nic->pf_index = nic_data->pf_index;
   133		vdpa_nic->vf_index = nic_data->vf_index;
   134		vdpa_nic->vdpa_state = EF100_VDPA_STATE_INITIALIZED;
   135		vdpa_nic->mac_address = (u8 *)&vdpa_nic->net_config.mac;
   136		ether_addr_copy(vdpa_nic->mac_address, mac);
   137		vdpa_nic->mac_configured = true;
   138	
   139		rc = get_net_config(vdpa_nic);
   140		if (rc)
   141			goto err_put_device;
   142	
   143		/* _vdpa_register_device when its ready */
   144	
   145		return vdpa_nic;
   146	
   147	err_put_device:
   148		/* put_device invokes ef100_vdpa_free */
   149		put_device(&vdpa_nic->vdpa_dev.dev);
   150		return ERR_PTR(rc);
   151	}
   152	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (322299 bytes)