netdev - [PATCH net-next 0/3] Trace points for mv88e6xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221207233954.3619276-1-vladimir.oltean@nxp.com>
Date:   Thu,  8 Dec 2022 01:39:51 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Hans J. Schultz" <netdev@...io-technology.com>
Subject: [PATCH net-next 0/3] Trace points for mv88e6xxx

While testing Hans Schultz' attempt at offloading MAB on mv88e6xxx:
https://patchwork.kernel.org/project/netdevbpf/cover/20221205185908.217520-1-netdev@kapio-technology.com/
I noticed that he still didn't get rid of the huge log spam caused by
ATU and VTU violations, even if we discussed about this:
https://patchwork.kernel.org/project/netdevbpf/cover/20221112203748.68995-1-netdev@kapio-technology.com/#25091076

It seems unlikely he's going to ever do this, so here is my own stab at
converting those messages to trace points. This is IMO an improvement
regardless of whether Hans' work with MAB lands or not, especially the
VTU violations which were quite annoying to me as well.

A small sample of before:

$ ./bridge_locked_port.sh lan1 lan2 lan3 lan4
[  114.465272] mv88e6085 d0032004.mdio-mii:10: VTU member violation for vid 100, source port 9
[  119.550508] mv88e6xxx_g1_vtu_prob_irq_thread_fn: 34 callbacks suppressed
[  120.369586] mv88e6085 d0032004.mdio-mii:10: VTU member violation for vid 100, source port 9
[  120.473658] mv88e6085 d0032004.mdio-mii:10: VTU member violation for vid 100, source port 9
[  125.535209] mv88e6xxx_g1_vtu_prob_irq_thread_fn: 21 callbacks suppressed
[  125.535243] mv88e6085 d0032004.mdio-mii:10: VTU member violation for vid 100, source port 9
[  125.981327] mv88e6085 d0032004.mdio-mii:10: VTU member violation for vid 100, source port 9
[  126.048694] mv88e6085 d0032004.mdio-mii:10: VTU member violation for vid 100, source port 9
[  126.090625] mv88e6085 d0032004.mdio-mii:10: VTU member violation for vid 100, source port 9
[  126.174558] mv88e6085 d0032004.mdio-mii:10: VTU member violation for vid 100, source port 9
[  129.400356] mv88e6085 d0032004.mdio-mii:10: ATU miss violation for 00:01:02:03:04:01 fid 3 portvec 4 spid 2
[  130.234055] mv88e6085 d0032004.mdio-mii:10: ATU miss violation for 00:01:02:03:04:01 fid 3 portvec 4 spid 2
[  130.338193] mv88e6085 d0032004.mdio-mii:10: ATU miss violation for 00:01:02:03:04:01 fid 3 portvec 4 spid 2
[  134.626099] mv88e6xxx_g1_atu_prob_irq_thread_fn: 38 callbacks suppressed
[  134.626132] mv88e6085 d0032004.mdio-mii:10: ATU miss violation for 00:01:02:03:04:01 fid 3 portvec 4 spid 2

and after:

$ trace-cmd record -e mv88e6xxx ./bridge_locked_port.sh lan1 lan2 lan3 lan4
$ trace-cmd report
   irq/35-moxtet-60    [000]    74.386799: mv88e6xxx_vtu_miss_violation: dev d0032004.mdio-mii:10 port 9 vid 100
   irq/35-moxtet-60    [000]    76.834759: mv88e6xxx_vtu_miss_violation: dev d0032004.mdio-mii:10 port 9 vid 100
   irq/35-moxtet-60    [000]    86.537973: mv88e6xxx_vtu_miss_violation: dev d0032004.mdio-mii:10 port 9 vid 100
   irq/35-moxtet-60    [000]    87.553885: mv88e6xxx_vtu_miss_violation: dev d0032004.mdio-mii:10 port 9 vid 100
   irq/35-moxtet-60    [000]   100.583426: mv88e6xxx_vtu_miss_violation: dev d0032004.mdio-mii:10 port 9 vid 100
   irq/35-moxtet-60    [000]   108.550520: mv88e6xxx_vtu_member_violation: dev d0032004.mdio-mii:10 port 9 vid 100
   irq/35-moxtet-60    [000]   109.054410: mv88e6xxx_vtu_member_violation: dev d0032004.mdio-mii:10 port 9 vid 100
   irq/35-moxtet-60    [000]   123.586896: mv88e6xxx_atu_miss_violation: dev d0032004.mdio-mii:10 port 2 addr 00:01:02:03:04:01 fid 3
   irq/35-moxtet-60    [000]   126.315529: mv88e6xxx_atu_miss_violation: dev d0032004.mdio-mii:10 port 2 addr 00:01:02:03:04:01 fid 3
   irq/35-moxtet-60    [000]   126.400709: mv88e6xxx_atu_miss_violation: dev d0032004.mdio-mii:10 port 2 addr 00:01:02:03:04:01 fid 3
   irq/35-moxtet-60    [000]   126.947391: mv88e6xxx_atu_miss_violation: dev d0032004.mdio-mii:10 port 2 addr 00:01:02:03:04:01 fid 3
   irq/35-moxtet-60    [000]   127.985090: mv88e6xxx_vtu_miss_violation: dev d0032004.mdio-mii:10 port 9 vid 100
   irq/35-moxtet-60    [000]   128.059140: mv88e6xxx_atu_miss_violation: dev d0032004.mdio-mii:10 port 2 addr 00:01:02:03:04:01 fid 3
   irq/35-moxtet-60    [000]   128.163132: mv88e6xxx_atu_miss_violation: dev d0032004.mdio-mii:10 port 2 addr 00:01:02:03:04:01 fid 3

Hans J. Schultz (1):
  net: dsa: mv88e6xxx: read FID when handling ATU violations

Vladimir Oltean (2):
  net: dsa: mv88e6xxx: replace ATU violation prints with trace points
  net: dsa: mv88e6xxx: replace VTU violation prints with trace points

 drivers/net/dsa/mv88e6xxx/Makefile      |  4 +
 drivers/net/dsa/mv88e6xxx/global1_atu.c | 81 +++++++++++++++-----
 drivers/net/dsa/mv88e6xxx/global1_vtu.c |  7 +-
 drivers/net/dsa/mv88e6xxx/trace.c       |  6 ++
 drivers/net/dsa/mv88e6xxx/trace.h       | 98 +++++++++++++++++++++++++
 5 files changed, 175 insertions(+), 21 deletions(-)
 create mode 100644 drivers/net/dsa/mv88e6xxx/trace.c
 create mode 100644 drivers/net/dsa/mv88e6xxx/trace.h

-- 
2.34.1