[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221208092411.1961448-1-yangyingliang@huawei.com>
Date: Thu, 8 Dec 2022 17:24:11 +0800
From: Yang Yingliang <yangyingliang@...wei.com>
To: <netdev@...r.kernel.org>
CC: <jdmason@...zu.us>, <davem@...emloft.net>, <edumazet@...gle.com>,
<kuba@...nel.org>, <pabeni@...hat.com>, <leon@...nel.org>
Subject: [PATCH net v3] ethernet: s2io: don't call dev_kfree_skb() under spin_lock_irqsave()
The dev_kfree_skb() is defined as consume_skb(), and it is not allowed
to call consume_skb() from hardware interrupt context or with interrupts
being disabled. So replace dev_kfree_skb() with dev_consume_skb_irq()
under spin_lock_irqsave().
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
---
v2 -> v3:
Update commit message.
v1 -> v2:
Add fix tag.
---
drivers/net/ethernet/neterion/s2io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c
index 1d3c4474b7cb..a83d61d45936 100644
--- a/drivers/net/ethernet/neterion/s2io.c
+++ b/drivers/net/ethernet/neterion/s2io.c
@@ -2386,7 +2386,7 @@ static void free_tx_buffers(struct s2io_nic *nic)
skb = s2io_txdl_getskb(&mac_control->fifos[i], txdp, j);
if (skb) {
swstats->mem_freed += skb->truesize;
- dev_kfree_skb(skb);
+ dev_consume_skb_irq(skb);
cnt++;
}
}
--
2.25.1
Powered by blists - more mailing lists