netdev - Re: [PATCH] libertas: fix memory leak in lbs_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5HeBT15/VTwazss@nanopsycho>
Date:   Thu, 8 Dec 2022 13:52:21 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, kvalo@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        johannes.berg@...el.com, dcbw@...hat.com, linville@...driver.com,
        hs4233@...l.mn-solutions.de, weiyongjun1@...wei.com,
        yuehaibing@...wei.com
Subject: Re: [PATCH] libertas: fix memory leak in lbs_init_adapter()

Thu, Dec 08, 2022 at 01:14:48PM CET, shaozhengchao@...wei.com wrote:
>When kfifo_alloc() failed in lbs_init_adapter(), cmd buffer is not
>released. Add free memory to processing error path.
>
>Fixes: 7919b89c8276 ("libertas: convert libertas driver to use an event/cmdresp queue")
>Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>