netdev - Re: [PATCH iproute2-next] libnetlink: Fix wrong netlink header placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2131854c-a23d-81a2-c9c4-5764e14b8afe@gmail.com>
Date:   Thu, 8 Dec 2022 09:07:45 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org, mlxsw@...dia.com
Subject: Re: [PATCH iproute2-next] libnetlink: Fix wrong netlink header
 placement

On 12/8/22 7:38 AM, Ido Schimmel wrote:
> The netlink header must be first in the netlink message, so move it
> there.
> 
> Fixes: fee4a56f0191 ("Update kernel headers")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  include/libnetlink.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/libnetlink.h b/include/libnetlink.h
> index 4d9696efa253..c91a22314548 100644
> --- a/include/libnetlink.h
> +++ b/include/libnetlink.h
> @@ -38,9 +38,9 @@ struct nlmsg_chain {
>  };
>  
>  struct ipstats_req {
> +	struct nlmsghdr nlh;
>  	struct if_stats_msg ifsm;
>  	char buf[128];
> -	struct nlmsghdr nlh;
>  };
>  
>  extern int rcvbuf;

thanks for noticing this. Must have been stale diff on the branch when I
was looking into the flex-array problem.