netdev - Re: [PATCH linux-next] net: hns3: use strscpy() to instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y5IMnKja6kyhuq01@corigine.com>
Date:   Thu, 8 Dec 2022 17:11:08 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     yang.yang29@....com.cn
Cc:     salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, brianvv@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, xu.panda@....com.cn
Subject: Re: [PATCH linux-next] net: hns3: use strscpy() to instead of
 strncpy()

On Thu, Dec 08, 2022 at 07:53:25PM +0800, yang.yang29@....com.cn wrote:
> From: Xu Panda <xu.panda@....com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
> 
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>

This change looks good to me, although it should probably be
tagged for 'net-next' rather than 'linux-next'.

  [PATCH net-next] net: hns3: use strscpy() to instead of strncpy

That notwithstanding,

Reviewed-by: Simon Horman <simon.horman@...igine.com>