lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Dec 2022 19:11:12 +0200 From: Vladimir Oltean <olteanv@...il.com> To: Jerry Ray <jerry.ray@...rochip.com> Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux@...linux.org.uk Subject: Re: [PATCH net-next v4 1/2] dsa: lan9303: Whitespace Only Please name the commit message something more specific than "Whitespace Only", that is likely to not be confused with some other patch. A "Whitespace Only" patch can take place anywhere in this file. Like "align dsa_switch_ops members". On Wed, Dec 07, 2022 at 05:28:27PM -0600, Jerry Ray wrote: > Whitespace preparatory patch, making the dsa_switch_ops table consistent. > No code is added or removed. > > Signed-off-by: Jerry Ray <jerry.ray@...rochip.com> > --- > drivers/net/dsa/lan9303-core.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c > index 80f07bd20593..d9f7b554a423 100644 > --- a/drivers/net/dsa/lan9303-core.c > +++ b/drivers/net/dsa/lan9303-core.c > @@ -1280,16 +1280,16 @@ static int lan9303_port_mdb_del(struct dsa_switch *ds, int port, > } > > static const struct dsa_switch_ops lan9303_switch_ops = { > - .get_tag_protocol = lan9303_get_tag_protocol, > - .setup = lan9303_setup, > - .get_strings = lan9303_get_strings, > - .phy_read = lan9303_phy_read, > - .phy_write = lan9303_phy_write, > - .adjust_link = lan9303_adjust_link, > - .get_ethtool_stats = lan9303_get_ethtool_stats, > - .get_sset_count = lan9303_get_sset_count, > - .port_enable = lan9303_port_enable, > - .port_disable = lan9303_port_disable, > + .get_tag_protocol = lan9303_get_tag_protocol, > + .setup = lan9303_setup, > + .get_strings = lan9303_get_strings, > + .phy_read = lan9303_phy_read, > + .phy_write = lan9303_phy_write, > + .adjust_link = lan9303_adjust_link, > + .get_ethtool_stats = lan9303_get_ethtool_stats, > + .get_sset_count = lan9303_get_sset_count, > + .port_enable = lan9303_port_enable, > + .port_disable = lan9303_port_disable, Do you use a text editor which highlights tabs? The members above this line are aligned with tabs, the ones below with spaces. Still not exactly what I'd call "consistent". > .port_bridge_join = lan9303_port_bridge_join, > .port_bridge_leave = lan9303_port_bridge_leave, > .port_stp_state_set = lan9303_port_stp_state_set, > -- > 2.17.1 >
Powered by blists - more mailing lists