netdev - Re: [PATCH net v2] net: mvneta: Fix an out of bounds check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 08 Dec 2022 17:20:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Dan Carpenter <error27@...il.com>
Cc:     thomas.petazzoni@...tlin.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net v2] net: mvneta: Fix an out of bounds check

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 7 Dec 2022 10:06:31 +0300 you wrote:
> In an earlier commit, I added a bounds check to prevent an out of bounds
> read and a WARN().  On further discussion and consideration that check
> was probably too aggressive.  Instead of returning -EINVAL, a better fix
> would be to just prevent the out of bounds read but continue the process.
> 
> Background: The value of "pp->rxq_def" is a number between 0-7 by default,
> or even higher depending on the value of "rxq_number", which is a module
> parameter. If the value is more than the number of available CPUs then
> it will trigger the WARN() in cpu_max_bits_warn().
> 
> [...]

Here is the summary with links:
  - [net,v2] net: mvneta: Fix an out of bounds check
    https://git.kernel.org/netdev/net/c/cdd97383e19d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html