netdev - Re: [PATCH net-next v2 09/15] ice: protect init and calibrating check in ice_ptp_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ebc6aad1-c997-78f1-8f26-95cd49ed1355@intel.com>
Date:   Thu, 8 Dec 2022 11:48:56 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        Tony Nguyen <anthony.l.nguyen@...el.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <netdev@...r.kernel.org>,
        <richardcochran@...il.com>, <leon@...nel.org>,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net-next v2 09/15] ice: protect init and calibrating check
 in ice_ptp_request_ts



On 12/7/2022 3:36 PM, Saeed Mahameed wrote:
> On 07 Dec 13:09, Tony Nguyen wrote:
>> /**
>>  * ice_ptp_tx_tstamp - Process Tx timestamps for a port
>>  * @tx: the PTP Tx timestamp tracker
>> @@ -788,10 +805,10 @@ ice_ptp_alloc_tx_tracker(struct ice_ptp_tx *tx)
>>         return -ENOMEM;
>>     }
>>
>> -    spin_lock_init(&tx->lock);
>> -
>>     tx->init = 1;
>>
>> +    spin_lock_init(&tx->lock);
>> +
> 
> this change is pointless.

Yes it has no functional change, but I found the code nicer to read with 
this last.

Thanks,
Jake