netdev - Re: [PATCH net-next v2] skbuff: Introduce slab_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221207183440.4c80918b@kernel.org>
Date:   Wed, 7 Dec 2022 18:34:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     syzbot+fda18eaa8c12534ccb3b@...kaller.appspotmail.com,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Pavel Begunkov <asml.silence@...il.com>,
        pepsipu <soopthegoop@...il.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Andrii Nakryiko <andrii@...nel.org>, ast@...nel.org,
        bpf <bpf@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Hao Luo <haoluo@...gle.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>, jolsa@...nel.org,
        KP Singh <kpsingh@...nel.org>, martin.lau@...ux.dev,
        Stanislav Fomichev <sdf@...gle.com>, song@...nel.org,
        Yonghong Song <yhs@...com>, netdev@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Rasesh Mody <rmody@...vell.com>,
        Ariel Elior <aelior@...vell.com>,
        Manish Chopra <manishc@...vell.com>,
        Menglong Dong <imagedong@...cent.com>,
        David Ahern <dsahern@...nel.org>,
        Richard Gobert <richardbgobert@...il.com>,
        David Rientjes <rientjes@...gle.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        GR-Linux-NIC-Dev@...vell.com, linux-hardening@...r.kernel.org
Subject: Re: [PATCH net-next v2] skbuff: Introduce slab_build_skb()

On Wed,  7 Dec 2022 16:02:13 -0800 Kees Cook wrote:
> Is this what you had in mind for this kind of change?

nice, thanks a lot!

the only thing left to do is kdoc updates:
 - the existing kdocs should no longer mention frag_size == 0
 - kdoc on the slab_build_skb() should say:

  /* build_skb() variant which can operate on slab buffers.
   * Note that this should be used sparingly as slab buffers
   * cannot be combined efficiently by GRO!
   */

But this can all be done by us in a follow up, there's probably
more cleaning we can do in those kdocs.

> v2: introduce separate helper (kuba)
> v1: https://lore.kernel.org/netdev/20221206231659.never.929-kees@kernel.org/