netdev - Re: [PATCH net-next v1 0/2] ethtool: use bits.h defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221207184029.3996bc5f@kernel.org>
Date:   Wed, 7 Dec 2022 18:40:29 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:     davem@...emloft.net, pabeni@...hat.com, netdev@...r.kernel.org,
        mkubecek@...e.cz
Subject: Re: [PATCH net-next v1 0/2] ethtool: use bits.h defines

On Wed,  7 Dec 2022 15:17:26 -0800 Jesse Brandeburg wrote:
> Change the ethtool files in the kernel, including uapi header files, to
> use the kernel style BIT() and BIT_ULL() functions instead of
> open-coding bit shift operations.
> 
> Making this change results in a more consistent presentation of bit-
> shift operations as well as reduces the further likelihood of mistaken
> (1 << 31) usage which omits the 1UL that is necessary to get an unsigned
> result of the shift.

Let's hear some opinions but the BIT / GENMASK macros are not
universally loved so conversion == cleanup may not obvious.