lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Dec 2022 09:58:31 +0200 From: Leon Romanovsky <leon@...nel.org> To: Yang Yingliang <yangyingliang@...wei.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com Subject: Re: [PATCH net v2 1/2] net: apple: mace: don't call dev_kfree_skb() under spin_lock_irqsave() On Wed, Dec 07, 2022 at 09:29:58AM +0800, Yang Yingliang wrote: > It is not allowed to call consume_skb() from hardware interrupt context > or with interrupts being disabled. So replace dev_kfree_skb() with > dev_consume_skb_irq() under spin_lock_irqsave(). > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Yang Yingliang <yangyingliang@...wei.com> > --- > v1 -> v2: > Add a fix tag. > --- > drivers/net/ethernet/apple/mace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/apple/mace.c b/drivers/net/ethernet/apple/mace.c > index d0a771b65e88..77b4ed05140b 100644 > --- a/drivers/net/ethernet/apple/mace.c > +++ b/drivers/net/ethernet/apple/mace.c > @@ -846,7 +846,7 @@ static void mace_tx_timeout(struct timer_list *t) > if (mp->tx_bad_runt) { > mp->tx_bad_runt = 0; > } else if (i != mp->tx_fill) { > - dev_kfree_skb(mp->tx_bufs[i]); > + dev_consume_skb_irq(mp->tx_bufs[i]); Same question, why did you chose dev_consume_skb_irq and not dev_kfree_skb_irq? Thanks > if (++i >= N_TX_RING) > i = 0; > mp->tx_empty = i; > -- > 2.25.1 >
Powered by blists - more mailing lists