netdev - Re: [PATCH 2/2] mac80211_hwsim: handle RTT requests with virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212090854.IADKAyXy-lkp@intel.com>
Date:   Fri, 9 Dec 2022 11:12:44 +0300
From:   Dan Carpenter <error27@...il.com>
To:     oe-kbuild@...ts.linux.dev, Jaewan Kim <jaewan@...gle.com>,
        johannes@...solutions.net, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
        kernel-team@...roid.com, adelva@...gle.com,
        Jaewan Kim <jaewan@...gle.com>
Subject: Re: [PATCH 2/2] mac80211_hwsim: handle RTT requests with virtio

Hi Jaewan,

https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jaewan-Kim/mac80211_hwsim-add-PMSR-capability-support/20221206-012111
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git main
patch link:    https://lore.kernel.org/r/20221205171851.2811239-2-jaewan%40google.com
patch subject: [PATCH 2/2] mac80211_hwsim: handle RTT requests with virtio
config: ia64-randconfig-m041-20221204
compiler: ia64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <error27@...il.com>

smatch warnings:
drivers/net/wireless/mac80211_hwsim.c:3239 mac80211_hwsim_send_pmsr_ftm_request_peer() warn: variable dereferenced before check 'request' (see line 3235)
drivers/net/wireless/mac80211_hwsim.c:3504 mac80211_hwsim_abort_pmsr() warn: inconsistent returns '&data->mutex'.
drivers/net/wireless/mac80211_hwsim.c:3800 hwsim_pmsr_report_nl() error: uninitialized symbol 'err'.

vim +/request +3239 drivers/net/wireless/mac80211_hwsim.c

8027b096313ab2 Jaewan Kim    2022-12-06  3230  static int mac80211_hwsim_send_pmsr_ftm_request_peer(struct sk_buff *msg,
8027b096313ab2 Jaewan Kim    2022-12-06  3231  						     struct cfg80211_pmsr_ftm_request_peer *request)
8027b096313ab2 Jaewan Kim    2022-12-06  3232  {
8027b096313ab2 Jaewan Kim    2022-12-06  3233  	void *ftm;
8027b096313ab2 Jaewan Kim    2022-12-06  3234  
8027b096313ab2 Jaewan Kim    2022-12-06 @3235  	if (!request->requested)
8027b096313ab2 Jaewan Kim    2022-12-06  3236  		return -EINVAL;
8027b096313ab2 Jaewan Kim    2022-12-06  3237  
8027b096313ab2 Jaewan Kim    2022-12-06  3238  	ftm = nla_nest_start(msg, NL80211_PMSR_TYPE_FTM);
8027b096313ab2 Jaewan Kim    2022-12-06 @3239  	if (!request)

if (!ftm) ?

8027b096313ab2 Jaewan Kim    2022-12-06  3240  		return -ENOBUFS;
8027b096313ab2 Jaewan Kim    2022-12-06  3241  
8027b096313ab2 Jaewan Kim    2022-12-06  3242  	if (nla_put_u32(msg, NL80211_PMSR_FTM_REQ_ATTR_PREAMBLE,
8027b096313ab2 Jaewan Kim    2022-12-06  3243  			request->preamble))
8027b096313ab2 Jaewan Kim    2022-12-06  3244  		return -ENOBUFS;
8027b096313ab2 Jaewan Kim    2022-12-06  3245  
8027b096313ab2 Jaewan Kim    2022-12-06  3246  	if (nla_put_u16(msg, NL80211_PMSR_FTM_REQ_ATTR_BURST_PERIOD,
8027b096313ab2 Jaewan Kim    2022-12-06  3247  			request->burst_period))
8027b096313ab2 Jaewan Kim    2022-12-06  3248  		return -ENOBUFS;
8027b096313ab2 Jaewan Kim    2022-12-06  3249  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp