lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Dec 2022 17:02:51 +0200 From: Vladimir Oltean <olteanv@...il.com> To: Arun Ramadoss <arun.ramadoss@...rochip.com> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com, andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk, Tristram.Ha@...rochip.com, richardcochran@...il.com, ceggers@...i.de Subject: Re: [Patch net-next v3 06/13] net: ptp: add helper for one-step P2P clocks On Fri, Dec 09, 2022 at 12:54:30PM +0530, Arun Ramadoss wrote: > From: Christian Eggers <ceggers@...i.de> > > For P2P delay measurement, the ingress time stamp of the PDelay_Req is > required for the correction field of the PDelay_Resp. The application > echoes back the correction field of the PDelay_Req when sending the > PDelay_Resp. > > Some hardware (like the ZHAW InES PTP time stamping IP core) subtracts > the ingress timestamp autonomously from the correction field, so that > the hardware only needs to add the egress timestamp on tx. Other > hardware (like the Microchip KSZ9563) reports the ingress time stamp via > an interrupt and requires that the software provides this time stamp via > tail-tag on tx. > > In order to avoid introducing a further application interface for this, > the driver can simply emulate the behavior of the InES device and > subtract the ingress time stamp in software from the correction field. > > On egress, the correction field can either be kept as it is (and the > time stamp field in the tail-tag is set to zero) or move the value from > the correction field back to the tail-tag. > > Changing the correction field requires updating the UDP checksum (if UDP > is used as transport). > > Signed-off-by: Christian Eggers <ceggers@...i.de> Arun, this needs your Signed-off-by: tag too. Sometimes patchwork catches tags like these and appends them to the patch automatically when you just reply with them on a new line. Works with Fixes:, Reviewed-by: and Acked-by: at least. If there are no other review concerns with this series and it's otherwise good to go, I suppose you could try that.
Powered by blists - more mailing lists