netdev - Re: [PATCH net-next v4 2/2] dsa: lan9303: Migrate to PHYLINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2022 20:07:28 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jerry.Ray@...rochip.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux@...linux.org.uk
Subject: Re: [PATCH net-next v4 2/2] dsa: lan9303: Migrate to PHYLINK

On Fri, Dec 09, 2022 at 06:00:47PM +0000, Jerry.Ray@...rochip.com wrote:
> > As a reader, I find my intelligence insulted by self-evident comments such as this.
> > 
> > Especially in contrast with the writes below to the MII_BMCR of the
> > Virtual PHY, which would certainly deserve a bit more of an explanation,
> > yet there is none there.
> > 
> 
> I struggle with the lack of comments I see in the kernel codebase. While
> experts can look at the source code and understand it, I find I spend a
> good deal of time chasing down macros - following data structures - and
> reverse engineering an understanding of the purpose of something that could
> have been explained in the maintained source.  In-line comments target the
> unfamiliar reader as there are a lot of us out here and far too few experts.
> But I do see your point and I'll try to do a better job on this.

I do see that maybe my observation about the rest of this driver's code
lacking comments might have been unfair to you since it's not you who
added that uncommented code. But still, let's try to add comments where
those add value, and there are plenty of other places in this driver
which sorely need that. I still maintain that "if (!dsa_is_cpu_port()) return"
doesn't need a repeat in words of what that set of instructions does.
Maybe why, or something that isn't completely obvious from actually
reading what's already in the code.