netdev - Re: [PATCH v2 net-next 3/4] net: dsa: mv88e6xxx: replace ATU violation prints with trace points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221209194042.hxsduaeutoe5wb3e@skbuf>
Date:   Fri, 9 Dec 2022 21:40:42 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Hans J. Schultz" <netdev@...io-technology.com>
Subject: Re: [PATCH v2 net-next 3/4] net: dsa: mv88e6xxx: replace ATU
 violation prints with trace points

On Fri, Dec 09, 2022 at 11:38:41AM -0800, Saeed Mahameed wrote:
> On 09 Dec 19:28, Vladimir Oltean wrote:
> > In applications where the switch ports must perform 802.1X based
> > authentication and are therefore locked, ATU violation interrupts are
> > quite to be expected as part of normal operation. The problem is that
> > they currently spam the kernel log, even if rate limited.
> > 
> > Create a series of trace points, all derived from the same event class,
> > which log these violations to the kernel's trace buffer, which is both
> > much faster and much easier to ignore than printing to a serial console.
> > 
> > New usage model:
> > 
> > $ trace-cmd list | grep mv88e6xxx
> > mv88e6xxx
> > mv88e6xxx:mv88e6xxx_atu_full_violation
> > mv88e6xxx:mv88e6xxx_atu_miss_violation
> > mv88e6xxx:mv88e6xxx_atu_member_violation
> > $ trace-cmd record -e mv88e6xxx sleep 10
> > 
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> 
> My knowledge on dsa is very limited but for the tracepoints logic:

There's nothing to know about DSA here, really.

> Reviewed-by: Saeed Mahameed <saeed@...nel.org>

Thanks for the review.